Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WithOperation func to loadtest usecase #454

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Add WithOperation func to loadtest usecase #454

merged 3 commits into from
Jun 9, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jun 9, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

I found that the method variable is not passed to loadtest service. without it, the loadtest app does not work correctly.
fixed it.

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@rinx
🐛 Add WithOperation func to loadtest usecase
da2ba56 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@pull-assistant
Copy link

pull-assistant bot commented Jun 9, 2020 •
edited
Loading

Score: 0.85

Best reviewed: commit by commit

Optimal code review plan

     🐛 Add WithOperation func to loadtest usecase

     ♻️ Refactor loadtest usecase New func

     ♻️ Use GRPCClient.Opts func

Powered by Pull Assistant. Last update da2ba56 ... f89fc37. Read the comment docs.

@rinx rinx requested review from kmrmt and kpango June 9, 2020 08:12
@rinx rinx requested a review from hlts2 June 9, 2020 08:13
@codecov
Copy link

codecov bot commented Jun 9, 2020 •
edited
Loading

Codecov Report

Merging #454 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #454      +/-   ##
=========================================
+ Coverage    7.82%   7.84%   +0.02%     
=========================================
  Files         389     388       -1     
  Lines       20003   19945      -58     
=========================================
  Hits         1565    1565              
+ Misses      18214   18156      -58     
  Partials      224     224

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 180d175...f89fc37. Read the comment docs.

@rinx
♻️ Refactor loadtest usecase New func
31a478a 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@github-actions github-actions bot added size/M and removed size/S labels Jun 9, 2020
kpango
kpango previously approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rinx
♻️ Use GRPCClient.Opts func
f89fc37 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
hlts2
hlts2 approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kpango
kpango approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit fcbf1b8 into master Jun 9, 2020
@kpango kpango deleted the bugfix/loadtest/add-with-operation-func branch June 9, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpango kpango kpango approved these changes

@hlts2 hlts2 hlts2 approved these changes

@kmrmt kmrmt Awaiting requested review from kmrmt

Assignees
No one assigned
Labels
area/tools/cli/loadtest priority/medium size/M type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rinx @kpango @hlts2